gh-115225: Raise error on unsupported ISO 8601 time strings #119339
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
benchatt
force-pushed
the
fix-issue-115225
branch
from
3bdb081 to
3a2fb63
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
benchatt
force-pushed
the
fix-issue-115225
branch
from
28dc6e7 to
8bc3c11
Compare
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
There was a problem hiding this comment.
One last thing before merge is I realized that this patch doesn't credit you. Do you want to add yourself to the news fragment and the ACKS file?
Those are not required, but it's commonly done and good to give credit where credit is due. 😅
|
Sure thing, I'm on a plane right now but I'll try to add those when I can
…On Thu, May 23, 2024, 20:42 Paul Ganssle ***@***.***> wrote:
***@***.**** approved this pull request.
One last thing before merge is I realized that this patch doesn't credit
you. Do you want to add yourself to the news fragment and the ACKS file
<https://github.com/python/cpython/blob/main/Misc/ACKS>?
Those are not required, but it's commonly done and good to give credit
where credit is due. 😅
------------------------------
In Misc/NEWS.d/next/Library/2024-05-21-19-10-30.gh-issue-115225.eRmfJH.rst
<#119339 (comment)>:
> @@ -0,0 +1 @@
+Raise error on certain technically valid but pathological ISO 8601 strings passed to :meth:`datetime.time.fromisoformat` that were previously parsed incorrectly.
If you want you can put (Patch by ...) with whatever name you are
comfortable using here at the end of this file
—
Reply to this email directly, view it on GitHub
<#119339 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4PWEAVV54EXYJMLJDMMNDZD2EHBAVCNFSM6AAAAABICFM2M6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZVGM3DINJWGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Some time strings that contain fractional hours or minutes are permitted by ISO 8601, but such strings are very unlikely to be intentional. The current parser does not parse such strings correctly or raise an error. This change raises a ValueError when hours or minutes contain a decimal mark.
Blurb was pointing at wrong meth name
benchatt
force-pushed
the
fix-issue-115225
branch
from
b160163 to
188a6da
Compare
Alright, those are ready! Let me know if anything's out of sync or unusual and I'll fix it. Thanks again! |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
|
@pganssle Not sure I was supposed to call on Bedevere again. Sorry about that! |
|
Just would like to ping real quick one more time, sorry for the bother
@pganssle
…On Sun, May 26, 2024, 15:54 bedevere-app[bot] ***@***.***> wrote:
Thanks for making the requested changes!
@pganssle <https://github.com/pganssle>: please review the changes made
to this pull request.
—
Reply to this email directly, view it on GitHub
<#119339 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4PWEDJM2A7LTUBM6Z5GZLZEJRZNAVCNFSM6AAAAABICFM2M6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGQZDEMJQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
…thon#119339) Some time strings that contain fractional hours or minutes are permitted by ISO 8601, but such strings are very unlikely to be intentional. The current parser does not parse such strings correctly or raise an error. This change raises a ValueError when hours or minutes contain a decimal mark. Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
…thon#119339) Some time strings that contain fractional hours or minutes are permitted by ISO 8601, but such strings are very unlikely to be intentional. The current parser does not parse such strings correctly or raise an error. This change raises a ValueError when hours or minutes contain a decimal mark. Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
…thon#119339) Some time strings that contain fractional hours or minutes are permitted by ISO 8601, but such strings are very unlikely to be intentional. The current parser does not parse such strings correctly or raise an error. This change raises a ValueError when hours or minutes contain a decimal mark. Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Some time strings that contain fractional hours or minutes are permitted by ISO 8601, but such strings are very unlikely to be intentional. The current parser does not parse such strings correctly or raise an error. This change raises a ValueError when hours or minutes contain a decimal mark.