Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-118998: Handle errors correctly in tmtotuple in timemodule #118999

Merged
merged 1 commit into from
May 13, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 13, 2024

I tried to keep the diff as minimal as possible.

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sobolevn sobolevn merged commit fc75792 into python:main May 13, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@sobolevn
Copy link
Member Author

Thanks for the reviews!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
…e` (pythonGH-118999)

(cherry picked from commit fc75792)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
…e` (pythonGH-118999)

(cherry picked from commit fc75792)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented May 13, 2024

GH-119018 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 13, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 13, 2024

GH-119019 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 13, 2024
sobolevn added a commit that referenced this pull request May 13, 2024
…le` (GH-118999) (#119018)

gh-118998: Handle errors correctly in `tmtotuple` in `timemodule` (GH-118999)
(cherry picked from commit fc75792)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request May 13, 2024
…le` (GH-118999) (#119019)

gh-118998: Handle errors correctly in `tmtotuple` in `timemodule` (GH-118999)
(cherry picked from commit fc75792)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants