-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-118469: Document sqlite3 PEP-249 constructors #118975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I don't think we should expose implementation details; instead, try to (re)use the wording of PEP-249 (or adapt it to fit within the sqlite3
docs).
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
No response for more than two months. Applied the |
There is also a competing PR up: |
📚 Documentation preview 📚: https://cpython-previews--118975.org.readthedocs.build/