Skip to content

gh-118469: Document sqlite3 PEP-249 constructors #118975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

firatv
Copy link

@firatv firatv commented May 12, 2024

@ghost
Copy link

ghost commented May 12, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@erlend-aasland erlend-aasland changed the title gh-118469: Add missing PEP-249 constructors gh-118469: Document sqlite3 PEP-249 constructors May 14, 2024
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I don't think we should expose implementation details; instead, try to (re)use the wording of PEP-249 (or adapt it to fit within the sqlite3 docs).

@bedevere-app
Copy link

bedevere-app bot commented May 14, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Jul 27, 2024
@erlend-aasland
Copy link
Contributor

Thanks for the PR! I don't think we should expose implementation details; instead, try to (re)use the wording of PEP-249 (or adapt it to fit within the sqlite3 docs).

No response for more than two months. Applied the pending label.

@erlend-aasland
Copy link
Contributor

There is also a competing PR up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting changes docs Documentation in the Doc dir pending The issue will be closed if no feedback is provided skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants