Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118868: logging QueueHandler fix passing of kwargs #118869

Merged
merged 8 commits into from
Jun 4, 2024
Merged

gh-118868: logging QueueHandler fix passing of kwargs #118869

merged 8 commits into from
Jun 4, 2024

Conversation

Kaundur
Copy link
Contributor

@Kaundur Kaundur commented May 9, 2024 •
edited by bedevere-app bot
Loading

@Kaundur Kaundur requested a review from vsajip as a code owner May 9, 2024 20:41
@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented May 9, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request May 9, 2024
Closed
nineteendo
nineteendo reviewed May 9, 2024
View reviewed changes
dolfinus
dolfinus reviewed May 11, 2024
View reviewed changes
Kaundur and others added 2 commits May 13, 2024 17:22
@Kaundur
Fixed issue where kwargs were no longer passed to the logging handler…
97efffb 
… QueueHandler. Removed 'respect_handler_level' from the kwargs before creating the QueueHandler
@Kaundur @nineteendo
Update Lib/test/test_logging.py
31673f2 
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
vsajip
vsajip requested changes May 13, 2024
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented May 13, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Kaundur and others added 3 commits May 13, 2024 18:05
@Kaundur @vsajip
Update Lib/logging/config.py
3181577 
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@Kaundur
Fixed issue where kwargs were no longer passed to the logging handler…
e840986 
… QueueHandler. Included suggested changes from vsajip
@Kaundur
Merge branch 'main' into pythongh-118868-QueueHandler-fix
2a93f36
@Kaundur
Copy link
Contributor Author

Kaundur commented May 13, 2024

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented May 13, 2024

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from vsajip May 13, 2024 17:23
@vsajip vsajip merged commit dce14bb into python:main Jun 4, 2024
34 of 37 checks passed
@vsajip vsajip added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jun 4, 2024
@miss-islington-app
Copy link

Thanks @Kaundur for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @Kaundur for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2024
@Kaundur @nineteendo
@vsajip @miss-islington
pythongh-118868: logging QueueHandler fix passing of kwargs (pythonGH…
cfea708 
…-118869)

(cherry picked from commit dce14bb)

Co-authored-by: Kaundur <kaundur@protonmail.com>
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-app
Copy link

bedevere-app bot commented Jun 4, 2024

GH-120031 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jun 4, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2024
@Kaundur @nineteendo
@vsajip @miss-islington
pythongh-118868: logging QueueHandler fix passing of kwargs (pythonGH…
bc7f8ee 
…-118869)

(cherry picked from commit dce14bb)

Co-authored-by: Kaundur <kaundur@protonmail.com>
Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
@bedevere-app
Copy link

bedevere-app bot commented Jun 4, 2024

GH-120032 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 4, 2024
vsajip pushed a commit that referenced this pull request Jun 4, 2024
@miss-islington
[3.12] gh-118868: logging QueueHandler fix passing of kwargs (GH-118869…
fe68908 
…) (GH-120031)

(cherry picked from commit dce14bb)
vsajip pushed a commit that referenced this pull request Jun 4, 2024
@miss-islington
[3.13] gh-118868: logging QueueHandler fix passing of kwargs (GH-118869…
feaecf8 
…) (GH-120032)

(cherry picked from commit dce14bb)
@Kaundur Kaundur deleted the gh-118868-QueueHandler-fix branch June 4, 2024 13:59
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@Kaundur @nineteendo
@vsajip @barneygale
pythongh-118868: logging QueueHandler fix passing of kwargs (pythonGH…
74bbf0e 
…-118869)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@Kaundur @nineteendo
@vsajip @noahbkim
pythongh-118868: logging QueueHandler fix passing of kwargs (pythonGH…
da91d8f 
…-118869)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Kaundur @nineteendo
@vsajip @estyxx
pythongh-118868: logging QueueHandler fix passing of kwargs (pythonGH…
ed5ef68 
…-118869)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolfinus dolfinus dolfinus left review comments

@nineteendo nineteendo nineteendo left review comments

@vsajip vsajip vsajip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kaundur @vsajip @dolfinus @nineteendo