gh-118771: Ensure names defined in optimizer.h start with Py/_Py #118825
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimizer.h
is included fromPython.h
, and defines some names that can clash with user code. They should be hidden or get thePy
/_Py
prefix.This PR:
struct _bloom_filter
struct _exit_data
_Py_
:uop_get_target
uop_get_exit_index
uop_get_jump_target
uop_get_error_target
optimize_func
typedefBLOOM_FILTER_WORDS
UOP_FORMAT_TARGET
UOP_FORMAT_EXIT
UOP_FORMAT_JUMP
UOP_FORMAT_UNUSED
Perhaps some of these should be in a private header instead?
Or perhaps some should be public?
@markshannon, could you clarify the intent here?
Py
/_Py
prefix #118771