Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-117139: Add header for tagged pointers #118330

Merged
merged 19 commits into from
Apr 30, 2024
Merged

gh-117139: Add header for tagged pointers #118330

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
209ddac
Add header for tagged pointers
Fidget-Spinner Apr 26, 2024
f783bc4
cleanup
Fidget-Spinner Apr 26, 2024
4c52acc
end EOL
Fidget-Spinner Apr 26, 2024
9e0ed42
fix warnings
Fidget-Spinner Apr 27, 2024
4610cac
format
Fidget-Spinner Apr 27, 2024
f0df2bc
make macro names more symmetrical
Fidget-Spinner Apr 28, 2024
35ac0ce
fix warning
Fidget-Spinner Apr 28, 2024
c08a6f5
address rest of review
Fidget-Spinner Apr 30, 2024
9b5f8b2
remove MAX_UNTAG_SCRATCH
Fidget-Spinner Apr 30, 2024
046e308
rename file
Fidget-Spinner Apr 30, 2024
1a7087e
rename header guards
Fidget-Spinner Apr 30, 2024
2090980
add xnewref
Fidget-Spinner Apr 30, 2024
2f50bcb
Add Py_STACKREF_NULL
Fidget-Spinner Apr 30, 2024
5961992
fix Windows build
Fidget-Spinner Apr 30, 2024
6bf6d44
try fix Windows for real this time
Fidget-Spinner Apr 30, 2024
003d274
address review
Fidget-Spinner Apr 30, 2024
7501357
revert hasdeferred refcount back to original file
Fidget-Spinner Apr 30, 2024
53608d7
remove decref_owned
Fidget-Spinner Apr 30, 2024
0131fc1
address review
Fidget-Spinner Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix Windows build
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Apr 30, 2024
commit 5961992d5b62c8999153b5cb3f55e58983276c5c
3 changes: 2 additions & 1 deletion Include/internal/pycore_stackref.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#endif

#include <stddef.h>
#include "pycore_gc.h"

// Mark an object as supporting deferred reference counting. This is a no-op
// in the default (with GIL) build. Objects that use deferred reference
Expand All @@ -29,7 +30,7 @@
uintptr_t bits;
} _PyStackRef;

static const _PyStackRef Py_STACKREF_NULL = ((_PyStackRef) { .bits = (uintptr_t)NULL });
static const _PyStackRef Py_STACKREF_NULL = ((_PyStackRef) { .bits = 0 });

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build and test (x64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows (free-threading) / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

Check failure on line 33 in Include/internal/pycore_stackref.h

View workflow job for this annotation

GitHub Actions / Windows / build (arm64) 

initializer is not a constant [D:\a\cpython\cpython\PCbuild\_freeze_module.vcxproj]

#ifdef Py_GIL_DISABLED
#define Py_TAG_DEFERRED (1)
Expand Down
Loading