Skip to content

Conversation

@methane
Copy link
Member

@methane methane commented Apr 19, 2024

@methane
Copy link
Member Author

methane commented Apr 19, 2024

sorry if there is a reason to use kwargs.

@methane
Copy link
Member Author

methane commented Apr 19, 2024

Maybe, you don't want to expose this option as public API.

@methane methane closed this Apr 19, 2024
@maxeonyx
Copy link

@methane I think this was a good PR? Although changing away from **kwargs back to just a named arg means that this change would break anyone providing invalid args.

And yeah possibly they didn't want to expose it? But why not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants