Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117945: Amend version changed annotation for os.path.ismount() #117947

Merged
merged 2 commits into from
Apr 16, 2024
Merged

gh-117945: Amend version changed annotation for os.path.ismount() #117947

merged 2 commits into from
Apr 16, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Apr 16, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Apr 16, 2024
@bedevere-app bedevere-app bot mentioned this pull request Apr 16, 2024
Closed
@nineteendo @AlexWaygood
Update Doc/library/os.path.rst
caa1f38 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@nineteendo nineteendo marked this pull request as ready for review April 16, 2024 21:11
hauntsaninja
hauntsaninja approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hauntsaninja hauntsaninja added the needs backport to 3.12 bug and security fixes label Apr 16, 2024
@hauntsaninja hauntsaninja merged commit a23fa33 into python:main Apr 16, 2024
29 checks passed
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2024
@nineteendo @miss-islington
pythongh-117945: Fix os.path.ismount() documentation (pythonGH-117947)
758c828 
(cherry picked from commit a23fa33)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 16, 2024

GH-117952 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Apr 16, 2024
hauntsaninja pushed a commit that referenced this pull request Apr 16, 2024
@miss-islington @nineteendo
[3.12] gh-117945: Fix os.path.ismount() documentation (GH-117947) (#…
5f4c7cf 
…117952)

gh-117945: Fix `os.path.ismount()` documentation (GH-117947)
(cherry picked from commit a23fa33)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@nineteendo nineteendo deleted the fix-os.path.ismount-docs branch April 17, 2024 05:09
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@nineteendo @diegorusso
pythongh-117945: Fix os.path.ismount() documentation (python#117947)
3086198
@nineteendo nineteendo changed the title gh-117945: Fix os.path.ismount() documentation gh-117945: Amend version changed annotation for os.path.ismount() Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nineteendo @hauntsaninja @AlexWaygood