gh-117945: Amend version changed annotation for os.path.ismount()
#117947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Apr 16, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
Thanks @nineteendo for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 16, 2024
(cherry picked from commit a23fa33) Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
|
GH-117952 is a backport of this pull request to the 3.12 branch. |
hauntsaninja
pushed a commit
that referenced
this pull request
Apr 16, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
nineteendo
changed the title
os.path.ismount() documentationos.path.ismount()
rpxchoudhury
added a commit
to rpxchoudhury/cpython
that referenced
this pull request
Apr 22, 2025
This fixes issue python#117947 by ensuring functions like shutil.copy, copy2, copyfile, copytree, and move consistently return str (using os.fspath()), even when passed pathlib.Path objects. All relevant return dst/return real_dst lines have been updated with os.fspath(...) to normalize the type. All shutil-related tests pass locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.ismount()wasn't added in Python 3.4 #117945📚 Documentation preview 📚: https://cpython-previews--117947.org.readthedocs.build/