Skip to content

gh-112075: Lock when inserting into shared keys #117824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

gh-112075: Lock when inserting into shared keys #117824

wants to merge 2 commits into from

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Apr 12, 2024 •
edited by bedevere-app bot
Loading

This is a draft PR similar to #117528, but:

  1. Separates out the handling of split keys
  2. Doesn't yet handle the necessary locking in _Py_dict_lookup for things like the PyDict_GetItemRef locking fallback.

@bedevere-app bedevere-app bot mentioned this pull request Apr 12, 2024
Closed
@colesbury colesbury mentioned this pull request Apr 12, 2024
Closed
@colesbury colesbury closed this Apr 26, 2024
@colesbury
Copy link
Contributor Author

Addressed in #117528

@colesbury colesbury deleted the gh-112075-lock-split-keys branch July 16, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane Awaiting requested review from methane methane will be requested when the pull request is marked ready for review methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colesbury