Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117606: Truncate extremely long error message in test_exceptions #117670

Merged
merged 2 commits into from
Apr 11, 2024
Merged

gh-117606: Truncate extremely long error message in test_exceptions #117670

merged 2 commits into from
Apr 11, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Apr 9, 2024 •
edited by bedevere-app bot
Loading

@nineteendo @AlexWaygood
Truncate extremely long error message
2858881 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app bedevere-app bot mentioned this pull request Apr 9, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Apr 9, 2024
@nineteendo nineteendo marked this pull request as ready for review April 9, 2024 09:36
@AlexWaygood AlexWaygood changed the title gh-117606: Truncate extremely long error message gh-117606: Truncate extremely long error message in test_exceptions Apr 11, 2024
@AlexWaygood AlexWaygood merged commit 02f1385 into python:main Apr 11, 2024
35 checks passed
@AlexWaygood AlexWaygood added the needs backport to 3.12 bug and security fixes label Apr 11, 2024
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 11, 2024
@nineteendo @AlexWaygood @miss-islington
pythongh-117606: Truncate extremely long error message in `test_excep…
deda2bc 
…tions` (pythonGH-117670)

(cherry picked from commit 02f1385)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 11, 2024

GH-117745 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Apr 11, 2024
@nineteendo nineteendo deleted the trunc-extremely-long-err-msg branch April 11, 2024 07:38
AlexWaygood added a commit that referenced this pull request Apr 11, 2024
@miss-islington @nineteendo @AlexWaygood
[3.12] gh-117606: Truncate extremely long error message in `test_exce…
2a50857 
…ptions` (GH-117670) (#117745)

gh-117606: Truncate extremely long error message in `test_exceptions` (GH-117670)
(cherry picked from commit 02f1385)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@nineteendo @AlexWaygood @diegorusso
pythongh-117606: Truncate extremely long error message in `test_excep…
f7547c6 
…tions` (python#117670)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nineteendo @AlexWaygood