Skip to content

gh-117658: Fix check_dump_traceback_threads in free-threaded build #117659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Apr 8, 2024

With the GIL disabled, the waiting thread may still be in the self.running.set() call when faulthandler dumps tracebacks.

With the GIL disabled, the waiting thread may still be in the
`self.running.set() ` call when faulthandler dumps tracebacks.
@@ -578,7 +578,7 @@ def run(self):
regex = r"""
^Thread 0x[0-9a-f]+ \(most recent call first\):
(?: File ".*threading.py", line [0-9]+ in [_a-z]+
){{1,3}} File "<string>", line 23 in run
){{1,3}} File "<string>", line (?:22|23) in run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might a bit puzzling to future readers... Perhaps we should add a short comment about this above the regex?

@colesbury colesbury merged commit 6edde8a into python:main Apr 9, 2024
@colesbury colesbury deleted the gh-117658-check_dump_traceback_threads branch April 9, 2024 15:50
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…ild (python#117659)

With the GIL disabled, the waiting thread may still be in the
`self.running.set() ` call when faulthandler dumps tracebacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants