gh-111726: Remove some unneeded doctests from sqlite3 docs#117623
Merged
erlend-aasland merged 3 commits intopython:mainfrom Apr 8, 2024
Merged
gh-111726: Remove some unneeded doctests from sqlite3 docs#117623erlend-aasland merged 3 commits intopython:mainfrom
erlend-aasland merged 3 commits intopython:mainfrom
Conversation
bedevere-app
bot
added
docs
erlend-aasland
added a commit
to sobolevn/cpython
that referenced
this pull request
Apr 8, 2024
erlend-aasland
commented
Apr 8, 2024
Contributor
Author
|
Let's go! |
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 8, 2024
) * remove load extension doctest since we cannot skip it conditionally * remove sys.unraisablehook example; using unraisable hooks is not "an improved debug experience" (cherry picked from commit e338e1a) Co-authored-by: Erlend E. Aasland <erlend@python.org>
|
GH-117625 is a backport of this pull request to the 3.12 branch. |
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
* remove load extension doctest since we cannot skip it conditionally * remove sys.unraisablehook example; using unraisable hooks is not "an improved debug experience"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improved debug experience"
There is no convenient way to conditionally run this test,
so don't bother1.
Doc/library/sqlite3.rsthas multiple doctest warnings #111726📚 Documentation preview 📚: https://cpython-previews--117623.org.readthedocs.build/
Footnotes
moreover, we should remove the SQL approach from that example; the recommended approach would be to use the Python API. ↩