Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117584: Raise TypeError for non-paths in posixpath.relpath() #117585

Merged
merged 5 commits into from
Apr 7, 2024
Merged

gh-117584: Raise TypeError for non-paths in posixpath.relpath() #117585

merged 5 commits into from
Apr 7, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Apr 6, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 6, 2024
Closed
@nineteendo nineteendo marked this pull request as ready for review April 6, 2024 16:43
@nineteendo @aisk
Update Misc/NEWS.d/next/Core and Builtins/2024-04-06-16-42-34.gh-issu…
27d0c70 
…e-117584.hqk9Hn.rst

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@aisk
Copy link
Contributor

aisk commented Apr 6, 2024 •
edited
Loading

If the ValueError is raised by if not path: check, the falsy values 0 and [] will also raise the same ValueError, which is also strange. Maybe we can change the check to if path == "".

nineteendo and others added 2 commits April 6, 2024 18:53
@nineteendo
Revert "Update Misc/NEWS.d/next/Core and Builtins/2024-04-06-16-42-34…
77837f5 
….gh-issue-117584.hqk9Hn.rst"

This reverts commit 27d0c70.
@nineteendo @aisk
Update Misc/NEWS.d/next/Core and Builtins/2024-04-06-16-42-34.gh-issu…
6da601d 
…e-117584.hqk9Hn.rst

Co-authored-by: AN Long <aisk@users.noreply.github.com>
@nineteendo
Copy link
Contributor Author

No we can not, that doesn't work for Pathlike objects nor bytes.

serhiy-storchaka
serhiy-storchaka approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 733e56e into python:main Apr 7, 2024
35 checks passed
@nineteendo nineteendo deleted the fix-posixpath.relpath branch April 7, 2024 11:16
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@nineteendo @diegorusso
pythongh-117584: Raise TypeError for non-paths in posixpath.relpath() (…
9c9d025 
…pythonGH-117585)
@nineteendo
Copy link
Contributor Author

@serhiy-storchaka can we back port this to 3.12? It's a pure bug fix.

@bedevere-app
Copy link

bedevere-app bot commented May 22, 2024

GH-119388 is a backport of this pull request to the 3.12 branch.

@serhiy-storchaka
Copy link
Member

I do not think this is a bug fix. Normally you should not pass None to relpath(), so this does not affect most of applications. If for some reasons you passed an argument of wrong type without checking it, and handle the resulting ValueError, changing the exception type to TypeError is a breaking change. Even if it is right in the long run, it should not be done is the bugfix release.

@nineteendo
Copy link
Contributor Author

Thanks, closed the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aisk aisk aisk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nineteendo @aisk @serhiy-storchaka