-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-117494: extract the Instruction Sequence data structure into a separate file #117496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just to confirm, this is a pure refactor with no new functionality? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the addition of PyObject_HEAD
headers is correct, but it looks good otherwise.
When you're done making the requested changes, leave the comment: |
Yes. |
Co-authored-by: Mark Shannon <mark@hotpy.org>
I have made the requested changes; please review again. |
Thanks for making the requested changes! @markshannon: please review the changes made to this pull request. |
|
Here's the relevant output for the failed test (test.test_dynamic.RebindBuiltinsTests.test_load_global_specialization_failure_keeps_oparg):
That's 341 successive (recursive?) calls to |
I don't see how this PR could have impacted the recursion depth. |
Yeah, it might be something else. I'm looking into it. |
This extracts the instruction sequence data structure to a separate file. Next will be to add the Python interface into this data structure.
Also simplifies
instr_sequence_to_cfg
through better abstraction.