Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-12822: use monotonic clock for condvar if possible #11723

Merged
merged 4 commits into from
Feb 20, 2019
Merged

bpo-12822: use monotonic clock for condvar if possible #11723

merged 4 commits into from
Feb 20, 2019

Conversation

methane
Copy link
Member

@methane methane commented Feb 1, 2019 •
edited by bedevere-bot
Loading

eamanu
eamanu reviewed Feb 2, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but for some reason on mac the tests fail

@methane methane force-pushed the pthread_condattr_setclock branch from 410adda to f636113 Compare February 3, 2019 07:02
@methane methane force-pushed the pthread_condattr_setclock branch from f636113 to 2deb0f6 Compare February 3, 2019 07:04
@methane methane changed the title [wip] bpo-12822: use monotonic clock for condvar if possible bpo-12822: use monotonic clock for condvar if possible Feb 5, 2019
@methane methane requested a review from vstinner February 5, 2019 23:21
@methane methane merged commit 001fee1 into python:master Feb 20, 2019
@methane methane deleted the pthread_condattr_setclock branch February 20, 2019 01:00
@methane methane mentioned this pull request Apr 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu left review comments

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@methane @eamanu @the-knights-who-say-ni @bedevere-bot