Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117074: Update Traversable.joinpath docs to the 3.11+ protocol #117113

Merged
merged 1 commit into from
Apr 2, 2024
Merged

gh-117074: Update Traversable.joinpath docs to the 3.11+ protocol #117113

merged 1 commit into from
Apr 2, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Mar 21, 2024 •
edited by github-actions bot
Loading

For the argument name, I used pathsegments to match pathlib docs, rather than descendants used in importlib_resources and the source.

📚 Documentation preview 📚: https://cpython-previews--117113.org.readthedocs.build/

@encukou encukou requested a review from jaraco March 21, 2024 09:00
@bedevere-app bedevere-app bot mentioned this pull request Mar 21, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Mar 21, 2024
@encukou encukou merged commit e569f91 into python:main Apr 2, 2024
29 checks passed
@encukou encukou deleted the importlib-resources-abc-doc branch April 2, 2024 14:08
jaraco
jaraco reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful. Thanks for doing it.

@encukou encukou added the needs backport to 3.12 bug and security fixes label Apr 5, 2024
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 5, 2024
@encukou @miss-islington
pythongh-117074: Update Traversable.joinpath docs to the 3.11+ protoc…
2d2e1eb 
…ol (pythonGH-117113)

(cherry picked from commit e569f91)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 5, 2024

GH-117571 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Apr 5, 2024
encukou added a commit that referenced this pull request Apr 5, 2024
@miss-islington @encukou
[3.12] gh-117074: Update Traversable.joinpath docs to the 3.11+ proto…
558b517 
…col (GH-117113) (GH-117571)

gh-117074: Update Traversable.joinpath docs to the 3.11+ protocol (GH-117113)
(cherry picked from commit e569f91)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@encukou @diegorusso
pythongh-117074: Update Traversable.joinpath docs to the 3.11+ protoc…
65d474e 
…ol (pythonGH-117113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaraco jaraco jaraco left review comments

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@encukou @jaraco