Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-116988: Remove duplicates of annotated_rhs in the Grammar #117004

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

Rexicon226
Copy link
Contributor

@Rexicon226 Rexicon226 commented Mar 19, 2024

closes: #116988

  • remove duplicates
  • reran make regen-pegen
  • adds a cast to _PyPegen_lookahead generation so it can be used with explicitly typed rules

Copy link

cpython-cla-bot bot commented Mar 19, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Mar 19, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Rexicon226 Rexicon226 changed the title gh-116988: Remove duplicates of annoted_rhs in the Grammar gh-116988: Remove duplicates of annotated_rhs in the Grammar Mar 19, 2024
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lysnikolaou
Copy link
Member

The Tests / CIFuzz (memory) failure is unrelated.

@Rexicon226
Copy link
Contributor Author

bump + updated to master

@pablogsal pablogsal merged commit 9b280ab into python:main Apr 24, 2024
41 checks passed
@Rexicon226 Rexicon226 deleted the fix-issue-116988 branch April 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the Grammar
4 participants