Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35537: Fix docstring typos in _use_posix_spawn() #11684

Merged
merged 1 commit into from
Jan 26, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions Lib/subprocess.py
Original file line number Diff line number Diff line change
Expand Up @@ -607,17 +607,17 @@ def getoutput(cmd):


def _use_posix_spawn():
"""Check is posix_spawn() can be used for subprocess.
"""Check if posix_spawn() can be used for subprocess.

subprocess requires a posix_spawn() implementation that reports properly
errors to the parent process, set errno on the following failures:
subprocess requires a posix_spawn() implementation that properly reports
errors to the parent process, & sets errno on the following failures:

* process attribute actions failed
* file actions failed
* exec() failed
* Process attribute actions failed.
* File actions failed.
* exec() failed.

Prefer an implementation which can use vfork in some cases for best
performances.
Prefer an implementation which can use vfork() in some cases for best
performance.
"""
if _mswindows or not hasattr(os, 'posix_spawn'):
# os.posix_spawn() is not available
Expand All @@ -642,15 +642,14 @@ def _use_posix_spawn():
# glibc 2.24 has a new Linux posix_spawn implementation using vfork
# which properly reports errors to the parent process.
return True
# Note: Don't use the POSIX implementation of glibc because it doesn't
# Note: Don't use the implementation in earlier glibc because it doesn't
# use vfork (even if glibc 2.26 added a pipe to properly report errors
# to the parent process).
except (AttributeError, ValueError, OSError):
# os.confstr() or CS_GNU_LIBC_VERSION value not available
pass

# By default, consider that the implementation does not properly report
# errors.
# By default, assume that posix_spawn() does not properly report errors.
return False


Expand Down