-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-35826: Fix typo in equivalent code of async with cond
#11681
Conversation
Change `lock.xxx` to `cond.xxx`
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Edit: You can try triggering AppVeyor by closing and opening the PR.
Thanks for the pointer! I'm trying it now:) |
Thank you! 👍 |
I'm having trouble backporting to |
GH-16720 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit d73ac0e) Co-authored-by: Kevin Mai-Husan Chia <mhchia@users.noreply.github.com>
Issues
The equivalent example code of
async with
statement withasyncio.Condition
has a typo.lock.xxx
should be changed tocond.xxx
.Changes
lock.acquire
tocond.acquire
lock.release
tocond.release
https://bugs.python.org/issue35826