Skip to content

gh-115664: Merge versionchanged directives for the same version #116456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 7, 2024

Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pathlib bits look good!

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change necessary? If there are multiple independent changes, I think it's clearer to use two separate directives.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@serhiy-storchaka
Copy link
Member Author

It is usually written in this way. If some changes use separate directives, it implies that there is a special meaning for this. Or that it is just an error.

You can more clearly see what changes were made in the same version.

@rhettinger rhettinger removed their request for review March 9, 2024 18:26
@hugovk hugovk removed the needs backport to 3.11 only security fixes label Apr 11, 2024
@hugovk
Copy link
Member

hugovk commented May 7, 2024

I think it's clearer by keeping it as-is, it makes it clear there's more than one change here -- I skim each one and decide if they're important.

With the merged one, I skim the "headline", and ignore the next one if the "headline" was less interesting.

Before

image

https://docs.python.org/3/library/collections.html#collections.Counter.update

After

image

https://cpython-previews--116456.org.readthedocs.build/en/116456/library/collections.html#collections.Counter.update

@nedbat
Copy link
Member

nedbat commented May 7, 2024

It seems like the "before" is preferred to "after", at least for now. We discussed this at the May 7 Docs Working Group.

@nedbat nedbat closed this May 7, 2024
@encukou
Copy link
Member

encukou commented May 7, 2024

The other PRs on this issue are great improvements though; thank you for those!

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented May 7, 2024

Yup, thanks for the other changes linked to #116456 ; they all look good. I also agree that we should keep separate changes in separate versionchanged; in addition to aesthetics and conceptual consistency I'd find it confusing to skim a version changed, see something that wasn't related to my use case, skip it and then find out later that buried later in the annotation there was an unrelated, relevant change. Also, it would interfere with the still in-progress work to enhance the versionmodified directives to output structured human- and machine-readable information about additions, changes and deprecations/removals.

@serhiy-storchaka
Copy link
Member Author

Thank you for your reviews. I agree, when the versionchanged directive includes several paragraphs, the formatting is unclear.

But I still think that notes about changes in function parameters could be in a single paragraph.

@erlend-aasland
Copy link
Contributor

But I still think that notes about changes in function parameters could be in a single paragraph.

I agree some of those could benefit from being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge docs Documentation in the Doc dir needs backport to 3.12 only security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants