-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-115664: Merge versionchanged directives for the same version #116456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-115664: Merge versionchanged directives for the same version #116456
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pathlib bits look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change necessary? If there are multiple independent changes, I think it's clearer to use two separate directives.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
It is usually written in this way. If some changes use separate directives, it implies that there is a special meaning for this. Or that it is just an error. You can more clearly see what changes were made in the same version. |
I think it's clearer by keeping it as-is, it makes it clear there's more than one change here -- I skim each one and decide if they're important. With the merged one, I skim the "headline", and ignore the next one if the "headline" was less interesting. Before![]() https://docs.python.org/3/library/collections.html#collections.Counter.update After![]() |
It seems like the "before" is preferred to "after", at least for now. We discussed this at the May 7 Docs Working Group. |
The other PRs on this issue are great improvements though; thank you for those! |
Yup, thanks for the other changes linked to #116456 ; they all look good. I also agree that we should keep separate changes in separate versionchanged; in addition to aesthetics and conceptual consistency I'd find it confusing to skim a version changed, see something that wasn't related to my use case, skip it and then find out later that buried later in the annotation there was an unrelated, relevant change. Also, it would interfere with the still in-progress work to enhance the |
Thank you for your reviews. I agree, when the But I still think that notes about changes in function parameters could be in a single paragraph. |
I agree some of those could benefit from being merged. |
📚 Documentation preview 📚: https://cpython-previews--116456.org.readthedocs.build/