Skip to content

gh-116397: Move the _PyGC_ClearAllFreeLists to the safe point #116414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Mar 6, 2024

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 9ec369f 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 6, 2024
@corona10 corona10 marked this pull request as ready for review March 6, 2024 14:27
@corona10 corona10 requested a review from colesbury March 6, 2024 14:27
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should run the refleak buildbots on this PR. If the refleak tracking or allocated blocks tests are a problem, we may also want to clear the current thread's free-list again after the GC (i.e., where we previously were calling _PyGC_ClearAllFreeLists()). That should be safe and I expect will fix the tests.

@corona10 corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 6, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 371b979 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 6, 2024
@corona10 corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 6, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @corona10 for commit be83eeb 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 6, 2024
@corona10 corona10 requested a review from colesbury March 6, 2024 15:27
@corona10 corona10 merged commit 2d4955f into python:main Mar 6, 2024
48 of 50 checks passed
@corona10 corona10 deleted the gh-116397 branch March 6, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants