Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-90437: Fix __main__.py documentation wording #116309

Merged
merged 6 commits into from
Jul 4, 2024
Merged

Conversation

tavallaie
Copy link
Contributor

@tavallaie tavallaie commented Mar 4, 2024

Complete fix for Issue #90437 with cherry-picked commits from @riqts and @merwok

This commit builds upon the previous work done by @riqts to address Issue #90437. It includes cherry-picked commits from their branch, ensuring their contributions are recognized and preserved in the project's history.

Cherry-picked commits:

  • Commit 1: Fixed simple __main__ typo (c30b653)
  • Commit 2: those files are kept short, importing functions to execute from other modules (0611a6c)

Special thanks to @riqts and @merwok for their initial contributions to this issue.

Ali Tavallaie


📚 Documentation preview 📚: https://cpython-previews--116309.org.readthedocs.build/

Copy link
Contributor

@ferdnyc ferdnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this back up, @tavallaie .

Doc/library/__main__.rst Outdated Show resolved Hide resolved
@tavallaie
Copy link
Contributor Author

I'll keep it updated until it merged

@brettcannon brettcannon added 3.12 bugs and security fixes 3.13 bugs and security fixes labels Jul 4, 2024
@brettcannon brettcannon self-assigned this Jul 4, 2024
@brettcannon brettcannon added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes and removed 3.12 bugs and security fixes 3.13 bugs and security fixes labels Jul 4, 2024
@brettcannon brettcannon merged commit cb688ba into python:main Jul 4, 2024
29 checks passed
@miss-islington-app
Copy link

Thanks @tavallaie for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 4, 2024
(cherry picked from commit cb688ba)

Co-authored-by: Ali Tavallaie <tavallaie@users.noreply.github.com>
Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Frank Dana <ferdnyc@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 4, 2024
(cherry picked from commit cb688ba)

Co-authored-by: Ali Tavallaie <tavallaie@users.noreply.github.com>
Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Frank Dana <ferdnyc@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 4, 2024

GH-121385 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 4, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 4, 2024

GH-121386 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 4, 2024
brettcannon pushed a commit that referenced this pull request Jul 4, 2024
…H-121386)

gh-90437: Fix __main__.py documentation wording (GH-116309)
(cherry picked from commit cb688ba)

Co-authored-by: Ali Tavallaie <tavallaie@users.noreply.github.com>
Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Frank Dana <ferdnyc@gmail.com>
brettcannon pushed a commit that referenced this pull request Jul 4, 2024
…121385)

gh-90437: Fix __main__.py documentation wording (GH-116309)
(cherry picked from commit cb688ba)

Co-authored-by: Ali Tavallaie <tavallaie@users.noreply.github.com>
Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Frank Dana <ferdnyc@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Frank Dana <ferdnyc@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Frank Dana <ferdnyc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants