Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115859: Re-enable T2 optimizer pass by default #116062

Merged
merged 9 commits into from
Feb 28, 2024
Merged

gh-115859: Re-enable T2 optimizer pass by default #116062

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d3a0695
Export sym_is_bottom
gvanrossum Feb 28, 2024
b834b29
Add a test that crashed before #116028
gvanrossum Feb 28, 2024
436a641
Tighten test (expect both guard and add)
gvanrossum Feb 28, 2024
e64d0c1
Add DECREF(temp) and out-of-space checks
gvanrossum Feb 28, 2024
66b76d5
Re-enable the optimizer
gvanrossum Feb 28, 2024
af72c76
Disable all of Tier 2 only if PYTHON_UOPS_OPTIMIZE=0
gvanrossum Feb 28, 2024
d7280d2
Fix tests skip for PYTHON_UOPS_OPTIMIZE
gvanrossum Feb 28, 2024
d2078db
Belt and suspenders -- use sym_matches_type before assert
gvanrossum Feb 28, 2024
bbe8cd9
Arrange things so DECREF(temp) happens even if sym_new_const() runs o…
gvanrossum Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a test that crashed before #116028
  • Loading branch information
@gvanrossum
gvanrossum committed Feb 28, 2024
commit b834b299b3775dbc1856dd4c87e35588d542ab62
15 changes: 15 additions & 0 deletions Lib/test/test_capi/test_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,5 +890,20 @@ def testfunc(n):
self.assertLessEqual(len(guard_both_float_count), 1)
self.assertIn("_COMPARE_OP_STR", uops)

def test_type_inconsistency(self):
def testfunc(n):
for i in range(n):
x = _test_global + _test_global
# Must be a real global else it won't be optimized to _LOAD_CONST_INLINE
global _test_global
_test_global = 0
_, ex = self._run_with_optimizer(testfunc, 16)
self.assertIsNone(ex)
_test_global = 1.2
_, ex = self._run_with_optimizer(testfunc, 16)
self.assertIsNotNone(ex)
self.assertIn("_BINARY_OP_ADD_INT", get_opnames(ex))


if __name__ == "__main__":
unittest.main()