gh-115421: Test that our Makefile has all needed test folders#115813
Merged
encukou merged 10 commits intopython:mainfrom Mar 7, 2024
Merged
gh-115421: Test that our Makefile has all needed test folders#115813encukou merged 10 commits intopython:mainfrom
encukou merged 10 commits intopython:mainfrom
Conversation
d9f6baf to
63ca14b
Compare
63ca14b to
b04014f
Compare
Member
Author
|
I've pushed a demo commit: f048fb5 It is missing |
AlexWaygood
reviewed
Feb 22, 2024
Member
Author
|
Correctly failed jobs (which detected missing
Now, I will revert |
Member
Author
|
Related failure: |
Member
Author
|
@Yhg1s it is ready :) |
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Member
Author
|
Thanks everyone! |
encukou
pushed a commit
to encukou/cpython
that referenced
this pull request
Mar 7, 2024
encukou
pushed a commit
to encukou/cpython
that referenced
this pull request
Mar 7, 2024
|
GH-116462 is a backport of this pull request to the 3.12 branch. |
1 similar comment
|
GH-116462 is a backport of this pull request to the 3.12 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Mar 7, 2024
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Mar 8, 2024
…hem (pythonGH-115813) (pythonGH-116462) * pythongh-115421: Test that our Makefile has all needed test folders (pythonGH-115813) * Update the list of installed test subdirectories --------- Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
|
GH-116498 is a backport of this pull request to the 3.11 branch. |
encukou
added a commit
that referenced
this pull request
Mar 11, 2024
…H-115813) This backports: - GH-115813 - GH-115422 Unlike on the main branch, new directories are added to the end, so they're a bit easier to patch out if a redistributor needs to do so. On main & 3.12, there's a special case for `idlelib/idle_test`; on 3.11 TESTSUBDIRS has several more entries that are not in `test/`. This backport ignores all of them (including idlelib). (The alternative would be list them, as additions to TEST_HOME_DIR. But that's probably too invasive; people might split stdlib up in surprising ways.) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the alternative to #115511
While we would still have to keep adding directories to
TESTSUBDIRSmanually, we would now have a test to catch any cases where people forget to update / remove these entries.This test works with
--disable-test-modulesas well.Which approach do you like best?