Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-35582: Inline arguments tuple unpacking in handwritten code. #11524

Merged

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 11, 2019

Inline PyArg_UnpackTuple() and _PyArg_UnpackStack() in performance
critical code in the builtins and operator modules.

https://bugs.python.org/issue35582

Inline PyArg_UnpackTuple() and _PyArg_UnpackStack() in performance
critical code in the builtins and operator modules.
@serhiy-storchaka
Copy link
Member Author

This PR rewrites again some of code changed in #11435. It looks now simpler but has the same performance.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please keep "w" variable in builtin_iter() as I proposed in a comment.

@serhiy-storchaka serhiy-storchaka merged commit 7934266 into python:master Jan 12, 2019
@serhiy-storchaka serhiy-storchaka deleted the inline-arg-tuple-unpack branch January 12, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance or resource usage skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants