Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-115026: AC should generate code that checks for errors of PyBuffer_FillInfo #115027

Merged
merged 1 commit into from
Feb 5, 2024
Merged

gh-115026: AC should generate code that checks for errors of PyBuffer_FillInfo #115027

merged 1 commit into from
Feb 5, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Feb 5, 2024 •
edited by bedevere-app bot
Loading

I've also changed 0 to be PyBUF_SIMPLE, because it is more canonical.

@bedevere-app bedevere-app bot mentioned this pull request Feb 5, 2024
Closed
serhiy-storchaka
serhiy-storchaka approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a real bug, but I do not mind to change the generated code, because it can provoke a bug if someone look at the Argument Clinic generated code and copy it with modifications.

@erlend-aasland erlend-aasland merged commit 87cd20a into python:main Feb 5, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn @aisk
pythongh-115026: Argument Clinic: handle PyBuffer_FillInfo errors in …
a198c8d 
…generated code (python#115027)
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@sobolevn @fsc-eriker
pythongh-115026: Argument Clinic: handle PyBuffer_FillInfo errors in …
1953754 
…generated code (python#115027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou encukou approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @encukou @serhiy-storchaka @erlend-aasland