-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ruff to 0.2.0 #114932
Bump ruff to 0.2.0 #114932
Conversation
I think the 3.12 one should be fine, though 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(Or unless you run with the
Sounds like we should add |
Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
(cherry picked from commit 920b89f) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
GH-114935 is a backport of this pull request to the 3.12 branch. |
Hmm maybe... I don't think it'll pass on the 3.11 branch though... But maybe that doesn't matter, since we won't actually run the check in CI? But it's pretty rare that we'll want to update the |
OK, let's skip it for 3.11 :) |
GH-115008 is a backport of this pull request to the 3.11 branch. |
Fix these DeprecationWarnings if you run
ruff
directly onLib/test
orTools/clinic
(which unfortunately you don't see if you run it via pre-commit, since pre-commit swallows all output from the underlying hook unless the hook returns a non-zero exit code):