Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-31450: Remove documentation mentioning that subprocess's child_tr… #11422

Merged
merged 1 commit into from
Jan 3, 2019
Merged

bpo-31450: Remove documentation mentioning that subprocess's child_tr… #11422

merged 1 commit into from
Jan 3, 2019

Conversation

harmands
Copy link
Contributor

@harmands harmands commented Jan 3, 2019 •
edited by bedevere-bot
Loading

bpo-31450: Remove documentation mentioning that subprocess's child_traceback is available with the parent process

https://bugs.python.org/issue31450

@harmands
bpo-31450: Remove documentation mentioning that subprocess's child_tr…
0d761e3 
…aceback is available with the parent process
@harmands harmands requested a review from gpshead as a code owner January 3, 2019 11:17
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 3, 2019
tirkarthi
tirkarthi approved these changes Jan 3, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems this was removed as part of fb94c5f (fb94c5f#diff-cc136486b4a8e112e64b57436a0619ebL1123) . Thanks.

eamanu
eamanu approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asvetlov
Copy link
Contributor

asvetlov commented Jan 3, 2019

@gpshead could you review?

@gpshead
Copy link
Member

gpshead commented Jan 3, 2019

I'm not sure the entire paragraph about exceptions from the child being re-raised even makes sense anymore given we do everything possible to never run Python code in the child... but this PR is definitely an improvement regardless so I'm merging as a starting point. :)

@gpshead gpshead merged commit 47a2fce into python:master Jan 3, 2019
@miss-islington
Copy link
Contributor

Thanks @harmands for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11426 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 3, 2019
@harmands @miss-islington
bpo-31450: Remove documentation mentioning that subprocess's child_tr…
b424034 
…aceback is available with the parent process (pythonGH-11422)

(cherry picked from commit 47a2fce)

Co-authored-by: Harmandeep Singh <harmandeep3091@gmail.com>
miss-islington added a commit that referenced this pull request Jan 3, 2019
@miss-islington @harmands
bpo-31450: Remove documentation mentioning that subprocess's child_tr…
47c035f 
…aceback is available with the parent process (GH-11422)

(cherry picked from commit 47a2fce)

Co-authored-by: Harmandeep Singh <harmandeep3091@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@eamanu eamanu eamanu approved these changes

@gpshead gpshead Awaiting requested review from gpshead

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@harmands @asvetlov @gpshead @miss-islington @bedevere-bot @tirkarthi @eamanu @the-knights-who-say-ni