Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35598: IDLE: Refactor globals in config_key.py #11392

Merged
merged 4 commits into from
Dec 31, 2018
Merged

bpo-35598: IDLE: Refactor globals in config_key.py #11392

merged 4 commits into from
Dec 31, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Dec 31, 2018 •
edited by bedevere-bot
Loading

  • Move translate_key to module level
  • Move key tuples to module level

https://bugs.python.org/issue35598

@csabella
bpo-35598: IDLE: Refactor globals in config_key.py
b96fc6f 
* Move translate_key to module level
* Move key tuples to module level
@terryjreedy
Merge remote-tracking branch 'origin/master' into pr_11392
1d5f0bf
@terryjreedy
Populate list_key_final immediately after creation.
c8a8227 
Separate load_final_key_list() is no longer needed after all
but one of its lines are moved to global scope.
@terryjreedy
Edit blurb.
cba9b2b
terryjreedy
terryjreedy approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make initial import slightly slower, repeated instantiations slightly faster, but maybe a millisecond either way. Removing the now unneeded function and its call makes the globalization look even more worthwhile.

@terryjreedy terryjreedy merged commit b4ea8bb into python:master Dec 31, 2018
@miss-islington
Copy link
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-11393 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 31, 2018
@csabella @miss-islington
bpo-35598: IDLE - Globalize some config_key objects (pythonGH-11392)
b131cd8 
Move translate_key() and constant tuples to module level.
Inline the remnant one-line function.
(cherry picked from commit b4ea8bb)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Dec 31, 2018
@miss-islington @csabella
bpo-35598: IDLE - Globalize some config_key objects (GH-11392)
74e4648 
Move translate_key() and constant tuples to module level.
Inline the remnant one-line function.
(cherry picked from commit b4ea8bb)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the configkey branch January 3, 2019 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csabella @miss-islington @bedevere-bot @terryjreedy @the-knights-who-say-ni