bpo-28503: Use crypt_r() when available instead of crypt() #11373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-11376 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 30, 2018
…11373) Use crypt_r() when available instead of crypt() in the crypt module. As a nice side effect: This also avoids a memory sanitizer flake as clang msan doesn't know about crypt's internal libc allocated buffer. (cherry picked from commit 387512c) Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead
pushed a commit
that referenced
this pull request
Dec 31, 2018
…GH-11376) Use crypt_r() when available instead of crypt() in the crypt module. As a nice side effect: This also avoids a memory sanitizer flake as clang msan doesn't know about crypt's internal libc allocated buffer. (cherry picked from commit 387512c) Co-authored-by: Gregory P. Smith <greg@krypto.org> [Google]
csabella
pushed a commit
to csabella/cpython
that referenced
this pull request
Dec 31, 2018
…11373) Use crypt_r() when available instead of crypt() in the crypt module. As a nice side effect: This also avoids a memory sanitizer flake as clang msan doesn't know about crypt's internal libc allocated buffer.
|
Unless I'm mistaken, this will add |
|
if you can demonstrate a problem, feel free to open a new bugs.python.org issue for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
crypt_rlibrary function instead ofcryptwhen available (currently Linux and FreeBSD) to avoid using static shared libc data structures.Motivation: This fixes a memory sanitizer failure due to it not understanding libc crypt()'s preallocated space.
We could release the GIL around the
crypt_rcall, but it is such a fast function anyways that seems rather silly. Do that in a followup PR if desired.https://bugs.python.org/issue28503