Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in documentation of AbstractEventLoopPolicy.set_child_watcher() #11369

Merged
merged 1 commit into from
Dec 30, 2018
Merged

Fix typo in documentation of AbstractEventLoopPolicy.set_child_watcher() #11369

merged 1 commit into from
Dec 30, 2018

Conversation

sth
Copy link
Contributor

@sth sth commented Dec 30, 2018

set_child_watcher() sets the watcher.

@sth sth requested review from 1st1 and asvetlov as code owners December 30, 2018 18:25
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 30, 2018
@asvetlov
Copy link
Contributor

Thanks!

@miss-islington miss-islington merged commit 1b29c03 into python:master Dec 30, 2018
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

@sth: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

@sth: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

1 similar comment
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@miss-islington
Copy link
Contributor

Thanks @sth for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11372 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2018
@sth @miss-islington
Fix typo in documentation of AbstractEventLoopPolicy.set_child_watche…
3623cda 
…r() (pythonGH-11369)

`set_child_watcher()` *sets* the watcher.
(cherry picked from commit 1b29c03)

Co-authored-by: sth <sth.dev@tejp.de>
miss-islington added a commit that referenced this pull request Dec 30, 2018
@miss-islington @sth
Fix typo in documentation of AbstractEventLoopPolicy.set_child_watche…
c74061d 
…r() (GH-11369)

`set_child_watcher()` *sets* the watcher.
(cherry picked from commit 1b29c03)

Co-authored-by: sth <sth.dev@tejp.de>
csabella pushed a commit to csabella/cpython that referenced this pull request Dec 31, 2018
@sth @csabella
Fix typo in documentation of AbstractEventLoopPolicy.set_child_watche…
b53e505 
…r() (pythonGH-11369)

`set_child_watcher()` *sets* the watcher.
@sth sth deleted the doc-set-child-watcher branch January 1, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sth @asvetlov @miss-islington @bedevere-bot @the-knights-who-say-ni