Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35598: IDLE: Increase test coverage for config_key.py #11360

Merged
merged 5 commits into from
Dec 30, 2018
Merged

bpo-35598: IDLE: Increase test coverage for config_key.py #11360

merged 5 commits into from
Dec 30, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Dec 29, 2018 •
edited by bedevere-bot
Loading

Add tests for function calls not previously covered. This does not include any refactoring, but there are some changes to config_key.py to facilitate testing.

https://bugs.python.org/issue35598

terryjreedy
terryjreedy approved these changes Dec 30, 2018
View reviewed changes
Lib/idlelib/idle_test/test_config_key.py Outdated
@@ -1,17 +1,20 @@
"Test config_key, coverage 82%"
"Test config_key, coverage 96%"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the result is 174 statements, 172 run, 2 missing, 8 excluded, 3 partial = 3 1/2 missing out of 172 = 2%. So I will bump up 96% to 98% and add explanation.

Lib/idlelib/idle_test/test_config_key.py

Coverage is effectively 100%. Tkinter dialog is mocked, Mac-only line
may be skipped, and dummy function in bind test should not be called.
Not tested: exit with 'self.advanced or self.keys_ok(keys)) ...' False.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little surprised that it should be possible to exit with OK instead of Cancel with bad non-blank key (which is ignored be leaving result as ''. Or maybe it is not and condition should be an assertion. Anyway, this is lower priority than the cancel issue, and might be looked at with the latter.

@terryjreedy terryjreedy merged commit b0a6196 into python:master Dec 30, 2018
@bedevere-bot
Copy link

@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11362 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 30, 2018
@csabella @miss-islington
bpo-35598: IDLE: Increase test coverage for config_key.py (pythonGH-1…
05bddec 
…1360)

(cherry picked from commit b0a6196)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Dec 30, 2018
@miss-islington @csabella
bpo-35598: IDLE: Increase test coverage for config_key.py (GH-11360)
34aadec 
(cherry picked from commit b0a6196)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@csabella csabella deleted the configkeytests branch December 30, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csabella @bedevere-bot @miss-islington @terryjreedy @the-knights-who-say-ni