Skip to content

bpo-35555: Create function to update IDLE menu item state #11343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2018
Merged

bpo-35555: Create function to update IDLE menu item state #11343

merged 1 commit into from
Dec 28, 2018

Conversation

csabella
Copy link
Contributor

@csabella csabella commented Dec 28, 2018 •
edited by bedevere-bot
Loading

  • Instead of updating menu state directly, create function to update the state.
  • Change outwin to call new function instead of updating menu directly.

https://bugs.python.org/issue35555

@csabella
Create function to update menu item state.
24357b3 
* Instead of updating menu state directly, create function
  to update the state.
* Change outwin to call function instead of updating menu
  directly.
eamanu
eamanu approved these changes Dec 28, 2018
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem a good improve on the code.

@terryjreedy terryjreedy merged commit 804a5d9 into python:master Dec 28, 2018
@miss-islington
Copy link
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11344 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 28, 2018
@csabella @miss-islington
IDLE: Create function to update menu item state. (pythonGH-11343)
5760821 
This will be needed for other menu items.  Change outwin to call the function instead of updating the menu item directly.
(cherry picked from commit 804a5d9)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@terryjreedy terryjreedy changed the title bpo-35555: IDLE: Create function to update menu item state bpo-35555: Create function to update IDLE menu item state Dec 28, 2018
miss-islington added a commit that referenced this pull request Dec 28, 2018
@miss-islington @csabella
IDLE: Create function to update menu item state. (GH-11343)
61775c3 
This will be needed for other menu items.  Change outwin to call the function instead of updating the menu item directly.
(cherry picked from commit 804a5d9)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@csabella @miss-islington @bedevere-bot @eamanu @the-knights-who-say-ni @terryjreedy