bpo-35588: Speed up mod, divmod and floordiv operations for Fraction type #11322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pelling out the numerator/denominator calculation, instead of instantiating and normalising Fractions along the way. This speeds up '%' and divmod() by 2-3x.
scoder
force-pushed
the
bpo35588-fraction-divmod
branch
from
a8607eb to
7a624bf
Compare
…rations to make it ~4x faster.
scoder
changed the title
eamanu
reviewed
Dec 26, 2018
Co-Authored-By: scoder <stefan_ml@behnel.de>
…ision should be an integer.
…r function _flat_divmod() since it's no longer reused.
…_() in order to simplify the implementation, even though performance results are mixed.
eamanu
reviewed
Dec 27, 2018
Misc/NEWS.d/next/Library/2018-12-26-10-55-59.bpo-35588.PSR6Ez.rst
Outdated
Show resolved
Hide resolved
asvetlov
approved these changes
Dec 27, 2018
|
@serhiy-storchaka the patch looks great for me. |
Co-Authored-By: scoder <stefan_ml@behnel.de>
serhiy-storchaka
approved these changes
Dec 27, 2018
Misc/NEWS.d/next/Library/2018-12-26-10-55-59.bpo-35588.PSR6Ez.rst
Outdated
Show resolved
Hide resolved
|
I'll merge this PR after New Year if @rhettinger and @mdickinson do not have objections. |
|
@serhiy-storchaka: Please replace |
|
Due to some GitHub bug my edition of the commit message was ignored, and changes were committed with an awful commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement mod and divmod operations for Fraction type by spelling out the numerator/denominator calculation, instead of instantiating and normalising Fractions along the way. This speeds up '%' and divmod() by 2-3x.
https://bugs.python.org/issue35588