Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Be explicit that Pathlib resolve was strict before 3.6. #11316

Merged
merged 1 commit into from
May 8, 2019
Merged

Doc: Be explicit that Pathlib resolve was strict before 3.6. #11316

merged 1 commit into from
May 8, 2019

Conversation

JulienPalard
Copy link
Member

From: https://mail.python.org/pipermail/docs/2018-December/038529.html

Not sure about the wording, can a native-english proofread this? :)

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting merge labels Dec 25, 2018
@csabella
Copy link
Contributor

LGTM. The wording conveys your meaning, so I think it's fine. If you wanted to be a little more formal, you can use Prior to 3.6, the behavior was always strict., but I don't know if it's necessary.

@pablogsal
Copy link
Member

pablogsal commented Dec 29, 2018 •
edited
Loading

LGTM but I also like @csabella suggestion, although I am fine either way :)

@JulienPalard JulienPalard merged commit 1d4b160 into python:master May 8, 2019
@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 8, 2019
@JulienPalard @miss-islington
Doc: Be explicit that Pathlib resolve was strict before 3.6. (pythonG…
e1cddff 
…H-11316)

(cherry picked from commit 1d4b160)

Co-authored-by: Julien Palard <julien@palard.fr>
@bedevere-bot
Copy link

GH-13190 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 8, 2019
@miss-islington @JulienPalard
Doc: Be explicit that Pathlib resolve was strict before 3.6. (GH-11316)
5e08fe1 
(cherry picked from commit 1d4b160)

Co-authored-by: Julien Palard <julien@palard.fr>
@JulienPalard JulienPalard deleted the pathlib-resolve-was-strict branch June 16, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamanu eamanu eamanu approved these changes

@pablogsal pablogsal pablogsal approved these changes

@csabella csabella csabella approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JulienPalard @csabella @pablogsal @miss-islington @bedevere-bot @eamanu @the-knights-who-say-ni