Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35525: Update the argument name for NNTP.starttls() #11310

Merged
merged 1 commit into from
Jan 2, 2019
Merged

bpo-35525: Update the argument name for NNTP.starttls() #11310

merged 1 commit into from
Jan 2, 2019

Conversation

harmands
Copy link
Contributor

@harmands harmands commented Dec 25, 2018 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 25, 2018
@harmands
Copy link
Contributor Author

Not sure, if the change should be in the documentation or the actual variable name should be changed in the code.

@taleinat taleinat merged commit e9a044e into python:master Jan 2, 2019
@miss-islington
Copy link
Contributor

Thanks @harmands for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11416 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2019
@harmands @miss-islington
bpo-35525: Correct the argument name for NNTP.starttls() (pythonGH-11310
ddc14f5 
)

(cherry picked from commit e9a044e)

Co-authored-by: Harmandeep Singh <harmandeep3091@gmail.com>
@bedevere-bot
Copy link

GH-11417 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2019
@harmands @miss-islington
bpo-35525: Correct the argument name for NNTP.starttls() (pythonGH-11310
f960959 
)

(cherry picked from commit e9a044e)

Co-authored-by: Harmandeep Singh <harmandeep3091@gmail.com>
miss-islington added a commit that referenced this pull request Jan 2, 2019
@miss-islington @harmands
bpo-35525: Correct the argument name for NNTP.starttls() (GH-11310)
d7cb203 
(cherry picked from commit e9a044e)

Co-authored-by: Harmandeep Singh <harmandeep3091@gmail.com>
@harmands harmands deleted the nntp_context branch January 3, 2019 03:14
ned-deily pushed a commit that referenced this pull request Jan 18, 2019
@miss-islington @harmands @ned-deily
bpo-35525: Correct the argument name for NNTP.starttls() (GH-11310) (G…
7887c02 
…H-11417)

(cherry picked from commit e9a044e)

Co-authored-by: Harmandeep Singh <harmandeep3091@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taleinat taleinat taleinat approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harmands @miss-islington @bedevere-bot @taleinat @the-knights-who-say-ni