gh-109802: Increase test coverage for complexobject.c #112452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* _Py_c_pow: L134 (this case goes to c_powi() due to L523), L139 // line numbers wrt to 54fbfa8
https://docs.python.org/3/library/stdtypes.html#hashing-of-numeric-types Inaccessible cases transformed to asserts.
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
* move test in test_bool() * drop redundant test class * test type in test_pos * avoid removing BINARY_OP instructions at compile time in arithmetic tests
serhiy-storchaka
added
tests
skirpichev
force-pushed
the
complex-cov-tests
branch
from
b36c10c to
c27feaa
Compare
serhiy-storchaka
approved these changes
Nov 28, 2023
|
Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 28, 2023
|
GH-112489 is a backport of this pull request to the 3.12 branch. |
|
Thank you for your contribution @skirpichev. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Nov 28, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line numbers are wrt to complexobject.c at 54fbfa8d5e.
This is #109642 without changes in complexobject.c (some dead code will be uncovered by tests in test_complex.py, test_cmath.py and test_capi/test_complex.py).