Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-112245: Promote free threaded CI #112246

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented Nov 18, 2023

this implements the changes proposed in GH-112245 and discussed on discourse, namely:

  1. Change the triggering of the free-threaded jobs to always trigger, instead of conditionally on the presence of the topic-free-threaded label.
  2. Remove the free-threaded jobs from the list of allowed failures (aka require that these jobs pass to get green signal).

@hugovk
Copy link
Member

hugovk commented Nov 18, 2023

Comparing the last build on main, which took 14 minutes from start to finish:

Details image

Altogether 1h 6m 4s of CI time:

Details image

Compared with this PR, which doubles many of the jobs, but only 22 minutes from start to finish:

Details image

Altogether 3h 4m 31s of CI time:

Details image

@hugovk
Copy link
Member

hugovk commented Nov 18, 2023

Approved per the reply given at https://discuss.python.org/t/is-it-time-to-promote-free-threaded-ci-and-buildbots/39064/4?u=hugovk

@itamaro
Copy link
Contributor Author

itamaro commented Nov 18, 2023

Altogether 3h 4m 31s of CI time:

wow, this is quite a significant increase in total CI time!
is this all free CI provided by GitHub, or is it paid for by the PSF? does GitHub have limits on usage per open-source project?

@hugovk
Copy link
Member

hugovk commented Nov 18, 2023

Yes, it's all free CI provided by GitHub for public repos. You can see the zeroes in the "billable time" columns above.

The usage limits mainly relate to max concurrent jobs: 20, or 5 for macOS:

https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#usage-limits

@carljm carljm merged commit 48dfd74 into python:main Nov 28, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@itamaro itamaro deleted the gh-112245-promote-free-threaded-ci branch April 9, 2024 15:30
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants