Minor refactoring of Object/abstract.c (UNARY_FUNC macro and more cases for BINARY_FUNC) #112145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(from python#111996) * PyNumber_AsSsize_t: remove inaccessible code (PyLong_AsSsize_t raises OverflowError) * Drop checks for broken float subclasses (like for PyNumber_Long in 31a6554) * Ternary ops (currently only pow/ipow) don't use __r*__ dunders, thus removal of testing last slot in ternary_op() * Use BINARY_FUNC macro for some remaining ops * Add UNARY_FUNC macro to define unary PyNumber_* functions
|
CC @serhiy-storchaka, this was abstract.c diff from the referenced pr. I hope this can skip issue and news entry... |
Huh. Is it worth or code should be kept intact? Reusing old or adding new macros is a secondary issue. All others related to a dead code (for different reasons). So, having something in common. |
This was referenced Dec 3, 2023
skirpichev
changed the title
|
@serhiy-storchaka, now this has only UNARY/BINARY_FUNC stuff. Probably this not worth an issue and can skip news. Description was updated. |
serhiy-storchaka
approved these changes
Dec 4, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…es for BINARY_FUNC) (pythonGH-112145) * Use BINARY_FUNC macro for some remaining ops * Add UNARY_FUNC macro to define unary PyNumber_* functions
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…es for BINARY_FUNC) (pythonGH-112145) * Use BINARY_FUNC macro for some remaining ops * Add UNARY_FUNC macro to define unary PyNumber_* functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// from #111996