Skip to content

[3.7] bpo-35513: Replace time.time() with time.monotonic() in tests (GH-11182) #11185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

[3.7] bpo-35513: Replace time.time() with time.monotonic() in tests (GH-11182) #11185

merged 1 commit into from
Dec 17, 2018

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 17, 2018 •
edited by bedevere-bot
Loading

Replace time.time() with time.monotonic() in tests to measure time
delta.

test_zipfile64: display progress every minute (60 secs) rather than
every 5 minutes (5*60 seconds).
(cherry picked from commit 2cf4c20)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue35513

@vstinner @miss-islington
bpo-35513: Replace time.time() with time.monotonic() in tests (python…
b255cb3 
…GH-11182)

Replace time.time() with time.monotonic() in tests to measure time
delta.

test_zipfile64: display progress every minute (60 secs) rather than
every 5 minutes (5*60 seconds).
(cherry picked from commit 2cf4c20)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot bedevere-bot mentioned this pull request Dec 17, 2018
Merged
vstinner
vstinner approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit be69ff2 into python:3.7 Dec 17, 2018
@miss-islington miss-islington deleted the backport-2cf4c20-3.7 branch December 17, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot