Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing colun in library/sys.po #11153

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Fixed missing colun in library/sys.po #11153

merged 1 commit into from
Dec 14, 2018

Conversation

Seluj78
Copy link
Contributor

@Seluj78 Seluj78 commented Dec 14, 2018 •
edited
Loading

Fixed missing colun in library/sys.po

bpo-35492: Fixed missing colun in library/sys.po

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 14, 2018
tiran
tiran approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

vstinner
vstinner approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miss-islington miss-islington merged commit cb0f5e2 into python:master Dec 14, 2018
@miss-islington
Copy link
Contributor

Thanks @Seluj78 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11154 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 14, 2018
@Seluj78 @miss-islington
Fixed missing colun in library/sys.po (pythonGH-11153)
6045c2a 
GH- Fixed missing colun in library/sys.po

[bpo-35492](https://bugs.python.org/issue35492): Fixed missing colun in library/sys.po
(cherry picked from commit cb0f5e2)

Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
@vstinner
Copy link
Member

There is just a typo in the commit: colun => colon, but @tiran already merged the change. Nah, nevermind, the commit message isn't important when fixing a typo ;-)

miss-islington added a commit that referenced this pull request Dec 14, 2018
@miss-islington @Seluj78
Fixed missing colun in library/sys.po (GH-11153)
5270085 
GH- Fixed missing colun in library/sys.po

[bpo-35492](https://bugs.python.org/issue35492): Fixed missing colun in library/sys.po
(cherry picked from commit cb0f5e2)

Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 23, 2018
@miss-islington @Seluj78 @ned-deily
Fixed missing colun in library/sys.po (pythonGH-11153)
c53e5f6 
GH- Fixed missing colun in library/sys.po

[bpo-35492](https://bugs.python.org/issue35492): Fixed missing colun in library/sys.po
(cherry picked from commit cb0f5e2)

Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Seluj78 @miss-islington @bedevere-bot @vstinner @tiran @the-knights-who-say-ni