Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-111062 CI: Update skip lists for resuable workflows #111521

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Oct 30, 2023

Add all the top-level jobs on the needs and allowed-skips lists, and add the build_*_free_threaded jobs on the allowed_failures list.

Rename build_win32, build_win_amd64 and build_win_arm64 to build_windows and build_windows_free_threaded in the skip/allow lists now they're in reusable workflows.

Here's a test build on my fork showing a docs-only build completing: hugovk#58

Compare #111509 which "failed" the "All required checks pass" check.

Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk
Copy link
Member Author

hugovk commented Oct 30, 2023

@webknjaz How does this look?

Copy link
Contributor

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk this should do. Although, the pre-reusable workflow might've required less jobs, IIRC. Nevertheless, this state is probably what you want.

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk merged commit 173d13b into python:main Oct 31, 2023
32 checks passed
@hugovk hugovk deleted the ci-update-skip-lists branch October 31, 2023 05:49
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants