Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in re docs #1113

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Fix typo in re docs #1113

merged 3 commits into from
Mar 23, 2018

Conversation

berkerpeksag
Copy link
Member

Reported by Maksym Nikulyak on docs.p.o.

@mention-bot
Copy link

@berkerpeksag, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ezio-melotti, @birkenfeld and @tiran to be potential reviewers.

vstinner
vstinner previously requested changes Apr 21, 2017
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the change is correct, I would prefer a link to the book rather than having to scroll 3 pages. I had to search manually in the doc to find it!

louisom
louisom reviewed Apr 22, 2017
View reviewed changes
Copy link
Contributor

@louisom louisom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a reference to the below seealso block

Doc/library/re.rst Outdated
@@ -67,7 +67,7 @@ operations; boundary conditions between *A* and *B*; or have numbered group
references. Thus, complex expressions can easily be constructed from simpler
primitive expressions like the ones described here. For details of the theory
and implementation of regular expressions, consult the Friedl book referenced
above, or almost any textbook about compiler construction.
below, or almost any textbook about compiler construction.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a reference to the seealso block

consult the Friedl book `mastering regular expressions`_ referenced below

.. _mastering regular expressions:

.. seealso::

@brettcannon
Copy link
Member

To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request.

If/when the requested changes have been made, please leave a comment that says, I have made the requested changes; please review again. That will trigger a bot to flag this pull request as ready for a follow-up review.

@berkerpeksag
Fix typo in re docs
c904912 
Reported by Maksym Nikulyak on docs.p.o.
@berkerpeksag berkerpeksag dismissed vstinner’s stale review March 23, 2018 13:15

Used citation instead of just typo fix.

@berkerpeksag berkerpeksag merged commit a0a42d2 into python:master Mar 23, 2018
@miss-islington
Copy link
Contributor

Thanks @berkerpeksag for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@berkerpeksag berkerpeksag deleted the re-docs-typo branch March 23, 2018 13:46
@bedevere-bot
Copy link

GH-6200 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2018
@berkerpeksag @miss-islington
Fix a reference to the MRE book in re docs (pythonGH-1113)
9e6e494 
Reported by Maksym Nikulyak on docs.p.o.
(cherry picked from commit a0a42d2)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 23, 2018
@berkerpeksag @miss-islington
Fix a reference to the MRE book in re docs (pythonGH-1113)
8abe95d 
Reported by Maksym Nikulyak on docs.p.o.
(cherry picked from commit a0a42d2)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
@bedevere-bot
Copy link

GH-6201 is a backport of this pull request to the 3.6 branch.

berkerpeksag added a commit that referenced this pull request Mar 23, 2018
@miss-islington @berkerpeksag
Fix a reference to the MRE book in re docs (GH-1113)
67d3f8b 
Reported by Maksym Nikulyak on docs.p.o.
(cherry picked from commit a0a42d2)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
berkerpeksag added a commit that referenced this pull request Mar 23, 2018
@miss-islington @berkerpeksag
Fix a reference to the MRE book in re docs (GH-1113)
fce39ab 
Reported by Maksym Nikulyak on docs.p.o.
(cherry picked from commit a0a42d2)

Co-authored-by: Berker Peksag <berker.peksag@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisom louisom louisom left review comments

@Mariatta Mariatta Mariatta approved these changes

@vstinner vstinner vstinner left review comments

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@berkerpeksag @mention-bot @brettcannon @miss-islington @bedevere-bot @vstinner @louisom @Mariatta @the-knights-who-say-ni