Skip to content

gh-106765: Building python 3.11.x installer FAILS, launcher.wixproj c… #110566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ to macOS framework and universal builds. Refer to `Mac/README.rst
On Windows, see `PCbuild/readme.txt
<https://github.com/python/cpython/blob/main/PCbuild/readme.txt>`_.

To build Windows installer, see `Tools/msi/README.txt
<https://github.com/python/cpython/blob/main/Tools/msi/README.txt>`_.

If you wish, you can create a subdirectory and invoke configure from there.
For example::

Expand Down
7 changes: 7 additions & 0 deletions Tools/msi/README.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ building on a recent Windows version, use the Control Panel (Programs | Programs
and Features | Turn Windows Features on or off) and ensure that the entry
".NET Framework 3.5 (includes .NET 2.0 and 3.0)" is enabled.

For Python 3.11.x and above, enable "Microsoft .NET Framework 4.8 Advanced Services"
instead of "Microsoft .NET Framework Version 3.5" available for Windows 10 and above.
Also make sure "MSVC v143 - VS 2022 C++ ARM64 build tools" are selected under
"Desktop Development with C++" in "Visual Studio installer" even if you are not
building on ARM64 along with other x64 related v143 build tools. This is because for
3.11.x and above we have upgraded to Wix-3.14.

For testing, the installer should be built with the Tools/msi/build.bat
script:

Expand Down