Skip to content

gh-110184: Fix subprocess test_pipesize_default() #110465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2023
Merged

gh-110184: Fix subprocess test_pipesize_default() #110465

merged 1 commit into from
Oct 6, 2023

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 6, 2023 •
edited by bedevere-app bot
Loading

For proc.stdin, get the size of the read end of the pipe.

Use subprocess context manager ("with proc:").

@vstinner
pythongh-110184: Fix subprocess test_pipesize_default()
f08aa06 
For proc.stdin, get the size of the read end of the pipe.

Use subprocess context manager ("with proc:").
@vstinner vstinner added tests Tests in the Lib/test dir skip news labels Oct 6, 2023
@vstinner vstinner requested a review from gpshead as a code owner October 6, 2023 10:26
@bedevere-app bedevere-app bot mentioned this pull request Oct 6, 2023
Closed
@vstinner vstinner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 6, 2023
@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023

!buildbot s390x

@bedevere-bot
Copy link

bedevere-bot commented Oct 6, 2023

🤖 New build scheduled with the buildbot fleet by @vstinner for commit f08aa06 🤖

The command will test the builders whose names match following regular expression: s390x

The builders matched are:

  • s390x SLES PR
  • s390x RHEL8 Refleaks PR
  • s390x Fedora Clang Installed PR
  • s390x RHEL7 LTO PR
  • s390x RHEL7 LTO + PGO PR
  • s390x RHEL8 LTO PR
  • s390x RHEL8 LTO + PGO PR
  • s390x Debian PR
  • s390x RHEL7 PR
  • s390x Fedora LTO PR
  • s390x Fedora Refleaks PR
  • s390x RHEL7 Refleaks PR
  • s390x RHEL8 PR
  • s390x Fedora PR
  • s390x Fedora LTO + PGO PR
  • s390x Fedora Clang PR

@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023

buildbot/s390x RHEL8 LTO PR

Failed with: Re-running test.test_multiprocessing_fork.test_processes in verbose mode.

@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023 •
edited
Loading

buildbot/s390x RHEL8 Refleaks PR

I stopped the build, Refleaks test is useless here.

@vstinner vstinner mentioned this pull request Oct 6, 2023
Merged
@vstinner vstinner merged commit d023d41 into python:main Oct 6, 2023
@vstinner vstinner deleted the test_pipesize_default branch October 6, 2023 13:44
@miss-islington
Copy link
Contributor

miss-islington commented Oct 6, 2023

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2023
@vstinner @miss-islington
pythongh-110184: Fix subprocess test_pipesize_default() (pythonGH-110465
3257f00 
)

For proc.stdin, get the size of the read end of the test pipe.

Use subprocess context manager ("with proc:").
(cherry picked from commit d023d41)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2023

GH-110471 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 6, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2023

GH-110472 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 6, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2023
@vstinner @miss-islington
pythongh-110184: Fix subprocess test_pipesize_default() (pythonGH-110465
f6c2512 
)

For proc.stdin, get the size of the read end of the test pipe.

Use subprocess context manager ("with proc:").
(cherry picked from commit d023d41)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Oct 6, 2023
@miss-islington @vstinner
[3.12] gh-110184: Fix subprocess test_pipesize_default() (GH-110465) (#…
7e07eca 
…110471)

gh-110184: Fix subprocess test_pipesize_default() (GH-110465)

For proc.stdin, get the size of the read end of the test pipe.

Use subprocess context manager ("with proc:").
(cherry picked from commit d023d41)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Oct 6, 2023
@miss-islington @vstinner
[3.11] gh-110184: Fix subprocess test_pipesize_default() (GH-110465) (#…
49a45f6 
…110472)

gh-110184: Fix subprocess test_pipesize_default() (GH-110465)

For proc.stdin, get the size of the read end of the test pipe.

Use subprocess context manager ("with proc:").
(cherry picked from commit d023d41)

Co-authored-by: Victor Stinner <vstinner@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-110184: Fix subprocess test_pipesize_default() (python#110465)
99f0a64 
For proc.stdin, get the size of the read end of the test pipe.

Use subprocess context manager ("with proc:").
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @bedevere-bot @miss-islington