-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Add version directives to ast docs #108788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versionadded directives for a bunch of the match nodes are rendered within the code blocks: https://cpython-previews--108788.org.readthedocs.build/en/108788/library/ast.html#ast.MatchAs
I didn't add these initially because other recently added objects didn't have them. Not sure if there's a reason behind that, but it seems useful to add the directives.
You might also want to add 3.8 for NamedExpr, which incidentally is misindented (https://docs.python.org/3.10/library/ast.html#ast.NamedExpr).
When you're done making the requested changes, leave the comment: |
Thank you! (I have made the requested changes; please review again) |
Thanks for making the requested changes! @JelleZijlstra: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build preview didn't update but I built locally and everything looks fine now, thanks!
We'll have to do a manual backport for 3.11.
Aside: maybe the build preview was slow to upload or cached or something, here's the new versionadded above the "Subscripting" header: https://cpython-previews--108788.org.readthedocs.build/en/108788/library/ast.html#subscripting |
Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
(cherry picked from commit 74fc96b) Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
GH-109106 is a backport of this pull request to the 3.12 branch. |
📚 Documentation preview 📚: https://cpython-previews--108788.org.readthedocs.build/