Skip to content

gh-108311: Fix test_store_attr_with_hint by disabling optimizer in decorator #108312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2023
Merged

gh-108311: Fix test_store_attr_with_hint by disabling optimizer in decorator #108312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73f8497
Fix test_store_attr_with_hint by disabling optimizer in decorator
gvanrossum Aug 22, 2023
876f948
fix lint
AlexWaygood Aug 22, 2023
0d0cb82
Move @disabling_optimizer to assert_races_do_not_crash()
gvanrossum Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Lib/test/test_opcache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,19 @@
import _testinternalcapi


def disabling_optimizer(func):
def wrapper(*args, **kwargs):
import _testinternalcapi
old_opt = _testinternalcapi.get_optimizer()
_testinternalcapi.set_optimizer(None)
try:
return func(*args, **kwargs)
finally:
_testinternalcapi.set_optimizer(old_opt)

return wrapper


class TestLoadSuperAttrCache(unittest.TestCase):
def test_descriptor_not_double_executed_on_spec_fail(self):
calls = []
Expand Down Expand Up @@ -502,6 +515,7 @@ def assert_specialized(self, f, opname):
opnames = {instruction.opname for instruction in instructions}
self.assertIn(opname, opnames)

@disabling_optimizer
def assert_races_do_not_crash(
self, opname, get_items, read, write, *, check_items=False
):
Expand Down