-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-95065, gh-107704: Argument Clinic: support multiple '/ [from ...]' and '* [from ...]' markers #108132
gh-95065, gh-107704: Argument Clinic: support multiple '/ [from ...]' and '* [from ...]' markers #108132
Conversation
… [from ...]' and '* [from ...]' markers
Indeed, the refactors from your previous PR came in handy here. |
Thanks, this is nice; @AlexWaygood, are you fine with this feature? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good to me! I'm impressed how little extra code it takes. I have one readability style nit.
I think we should maybe also add one or two examples to https://docs.python.org/3.13/howto/clinic.html#how-to-deprecate-passing-parameters-positionally-or-by-keyword that have mutliple / [from ...]
and * [from ...]
markers
It does not even make the code much more complex. Simply the code which checks that the version is the same is replaced with the code which supports multiple versions.