Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for automatic issue headers #108054

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

AA-Turner
Copy link
Member

xref: #108033 (comment)

As per Alex, please feel free to test at https://github.com/AA-Turner/cpython/issues/new/choose

A

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javascript isn't my strong suit, but this approach makes sense to me, as far as I can tell! And it seems to work pretty well :)

Will wait for another review before merging, though

@AA-Turner
Copy link
Member Author

For reference, the ocktokit docs:

And the GitHub docs for the return object schemas:

A

@hugovk
Copy link
Member

hugovk commented Aug 17, 2023

This can cause conflicts if you click to edit right after posting, and in the meantime the action adds the header. When you try and save it shows:

image

It would be nicer to avoid this if possible, but I guess we'd need some of the workarounds from #108033 (comment) onward, like having a somehow textbox near the top.

And, well, we can also get conflicts with the RTD link addition, but that's docs only PRs and this is for most issues.

@AlexWaygood
Copy link
Member

This can cause conflicts if you click to edit right after posting, and in the meantime the action adds the header.

In the spirit of EAFP, we could try this out, and see if we get any complaints?

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure :)

@AlexWaygood AlexWaygood merged commit 4cb0818 into python:main Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants