Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the GitHub issue templates into GitHub issue forms #107920

Merged
merged 26 commits into from
Aug 14, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Aug 13, 2023

This creates a much nicer interface for users filing issues with CPython.

Issue templates only apply to the main branch, so there's no way of testing these changes unless they're already merged into the main branch of a GitHub repository. Therefore, that's what I've done with my fork! These changes have already been merged into the main branch of https://github.com/AlexWaygood/cpython. Feel free to create issues over at my fork and test out what the experience of filling in the forms is like. I've also created some example issues so that you can see how the bug reports are rendered after the form has been filled in:

Documentation for this GitHub feature can be found here: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-issue-forms. (This page also includes an example of how to convert an existing issue template into an issue form.)

Detailed documentation for the permitted syntax in GitHub forms can be found here: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! I think there are some presentational issues (YAML multilines...) and a few points on wording/content.

A

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the comments (e.g. dropdown for the OSs and removing a few textareas) apply to all forms.

In addition, are you planning to convert the documentation template too?

AlexWaygood and others added 3 commits August 13, 2023 17:11
@AlexWaygood
Copy link
Member Author

In addition, are you planning to convert the documentation template too?

I don't think it really needs changing? Most of the docs issues that are filed don't seem like they're particularly lacking in information to me. In my opinion it's fine to leave the docs template as-is, unless you disagree :)

AlexWaygood and others added 3 commits August 13, 2023 20:48
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
AlexWaygood and others added 2 commits August 13, 2023 21:02
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@AlexWaygood AlexWaygood requested a review from hugovk August 13, 2023 20:09
AlexWaygood and others added 4 commits August 13, 2023 21:51
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@AlexWaygood AlexWaygood requested a review from hugovk August 13, 2023 21:01
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

AlexWaygood and others added 2 commits August 14, 2023 22:58
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@AlexWaygood AlexWaygood requested a review from AA-Turner August 14, 2023 22:07
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, all looks good!

A

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Aug 14, 2023

Thanks everybody for the thorough reviews, much appreciated!

@AlexWaygood AlexWaygood enabled auto-merge (squash) August 14, 2023 22:17
@AlexWaygood AlexWaygood merged commit 8d3cb1b into python:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants